Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added full-screen functionality #549

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

ivntsng
Copy link
Contributor

@ivntsng ivntsng commented Nov 6, 2024

What does this PR do?

  • Adds full screen support for URDF viewer.

What issues does this PR fix or reference?
#547

If this PR changes the UI, include a screenshot below.

Screenshot 2024-11-06 at 1 46 11 PM Screenshot 2024-11-06 at 1 46 22 PM

@ivntsng ivntsng linked an issue Nov 6, 2024 that may be closed by this pull request
@ivntsng ivntsng requested a review from codekansas November 6, 2024 21:46
@ivntsng ivntsng self-assigned this Nov 6, 2024
Copy link
Member

@codekansas codekansas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome - no comments

Comment on lines +219 to +226
const storedPosition = jointPositionsRef.current.find(
(pos) => pos.name === joint.name,
);
const initialValue = storedPosition
? storedPosition.value
: min <= 0 && max >= 0
? 0
: (min + max) / 2;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@ivntsng ivntsng merged commit 1f17676 into master Nov 6, 2024
1 check passed
@ivntsng ivntsng deleted the 547-urdf-viewer-full-screen-mode branch November 6, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URDF viewer full-screen mode
2 participants